graphql-dotnet / graphql-dotnet/parser

Handle whitespaces somehow

Open
#360 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
219
Forks
41
PR merge metrics
No merged PRs in 30d

Description

` @my @your` instead of `@my @your` now. It could be fixes as well checking parent node but for directives parent is always not null - it is `Directives` container, so actually grand parent is needed. Moreover, even after such check some tests failed (see `Printer_Should_Print_Pretty_If_Directives_Skipped`). The core problem is that some arbitrary nodes **can be** skipped so it's not obvious how to handle whitespaces at all. General approach may be to require each node to print their leading whitespace if it should do that. Downside - it will complicate all printing code. I do not want to do that just to handle very rare cases.

_Originally posted by @sungam3r in https://github.com/graphql-dotnet/parser/pull/359#discussion_r1360220872_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.