graphql-dotnet / graphql-dotnet/graphql-client

WebSocket close status and reason not handled

Open
#663 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
648
Forks
136
PR merge metrics
No merged PRs in 30d

Description

When the ws socket gets closed by peer, a closeResponse object is created but never used.
As the peer also is able to specify a close status + reason if would be nice to fetch these as well.

Today an exception is thrown with the message "Connection closed by the server", making it hard to take action as the reason for closure isn't known. My proposal is to throw a custom exception, including the close status, reason and the closeResponse message.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.