graphql-dotnet / graphql-dotnet/graphql-client

Intent of GraphQLRequest.GetHashCode()

Open
#385 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
648
Forks
136
PR merge metrics
No merged PRs in 30d

Description

https://github.com/graphql-dotnet/graphql-client/blob/0b49bfcc59dbd21837eb1732cc01c354efb341d4/src/GraphQL.Primitives/GraphQLRequest.cs#L87

Is the intent of this to return the same hash based on the property values in any instance? It won't work as a "these two objects have the same property values" hash because Variables is an object and object.GetHashCode generally returns a hash to the instance in memory.

If you're using it as an "instance" hash that's fine - but you don't really need the Tuple then. You could just do Variables.ToString(). But if this is to indicate that two or more instances of this class contain the same property values, I don't think that's ever true.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.