graphprotocol / graphprotocol/indexer

Counter-intuitive response from indexer cli

Open
#515 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
262
Forks
148
PR merge metrics
No merged PRs in 30d

Description

The UX coming from the indexer CLI is counter-intuitive. When executing a set of actions, the CLI reports back "No items found", indicating that it did nothing. However, it does seem to attempt some on-chain behaviour. Can we improve this?

indexer@indexer-shell-0 [~] $ graph indexer actions approve 91 92 93 94
✔ Processed input parameters
✔ Actions approved
┌────┬──────────┬────────────────────────────────────────────────┬──────────────┬────────────────┬──────┬───────┬──────────┬──────────┬───────────────┬───────────────┐
│ id │ type     │ deploymentID                                   │ allocationID │ amount         │ poi  │ force │ priority │ status   │ source        │ reason        │
├────┼──────────┼────────────────────────────────────────────────┼──────────────┼────────────────┼──────┼───────┼──────────┼──────────┼───────────────┼───────────────┤
│ 91 │ allocate │ QmcpX4ScNaWfSE1ZmfEFM3mPSCz5frk6edwsYMAvfGtrXV │ null         │ 4495710.291212 │ null │ null  │ 0        │ approved │ AllocationOpt │ AllocationOpt │
├────┼──────────┼────────────────────────────────────────────────┼──────────────┼────────────────┼──────┼───────┼──────────┼──────────┼───────────────┼───────────────┤
│ 92 │ allocate │ QmVQdzeGdPUiLiACeqXRpKAYpyj8Z1yfWLMUq7A7WundUf │ null         │ 6538176.653363 │ null │ null  │ 0        │ approved │ AllocationOpt │ AllocationOpt │
├────┼──────────┼────────────────────────────────────────────────┼──────────────┼────────────────┼──────┼───────┼──────────┼──────────┼───────────────┼───────────────┤
│ 93 │ allocate │ QmWkVS3Uzr2WsTwvxtte2dpHbSYJSQ1bTQMVciKXCWx7TM │ null         │ 1440996.064083 │ null │ null  │ 0        │ approved │ AllocationOpt │ AllocationOpt │
├────┼──────────┼────────────────────────────────────────────────┼──────────────┼────────────────┼──────┼───────┼──────────┼──────────┼───────────────┼───────────────┤
│ 94 │ allocate │ QmaaDA7XVVktfxCLMgfwG1z3KM8DSMoLkbemkTt9mQT8Qf │ null         │ 4157018.748012 │ null │ null  │ 0        │ approved │ AllocationOpt │ AllocationOpt │
└────┴──────────┴────────────────────────────────────────────────┴──────────────┴────────────────┴──────┴───────┴──────────┴──────────┴───────────────┴───────────────┘
indexer@indexer-shell-0 [~] $ graph indexer actions execute approved
✔ Executed approved actions
No items found
indexer@indexer-shell-0 [~] $ 

Affected version: v0.20.3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported indexer actions approve 91 92 93 94 and indexer actions execute approved commands against the affected v0.20.3 behavior, then trace the indexer actions CLI entry point. The completed change should make the execute command's output accurately reflect whether approved actions were processed instead of reporting No items found after execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.