graphprotocol / graphprotocol/graph-node

[Feature] Declarative Call Enforcement

Open
#6,211 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Description

We have run into some declarative calls failing. In our mappings we utilize the try_{ethCall} in order to get things like token.name, token.symbol, token.decimals however in rare circumstances contracts will not have this functionality. Rather than failing the subgraph I would prefer that declarative calls simple try to make the eth call.

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out
  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how declarative calls using try_{ethCall} are handled in graph-node and how failed calls currently affect subgraph execution. Review the existing call-handling path and determine the behavior needed for contracts without these methods; done means such failures no longer fail the subgraph.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.