graphprotocol / graphprotocol/graph-node

[Bug] graphman accepts deployment or namespace misleading to errors

Open
#5,270 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/graphman bug Stale
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Bug report

In graphman help, like graphman drop --help it accepts the DEPLOYMENT as an identifier to which SG to remove. The Deployment is unique everywhere in our system and if I try to drop a SG by using the deployment it will get removed from everywhere as usual.

The problem is that the drop command also accepts the namespace, which is unique only to the respective shard where this SG is deployed.

The graphman shouldn't accept the namespace if the help is saying to use the deployment identifier, otherwise it leads to critical mistakes when we want to remove the SG only from a specific shard and not from everywhere.

Also if you might consider this also as a feature request, there should be a possibility to drop the SG only from a specific shard by using it's namespace (if it's a single SG in that table, otherwise throw a warning that's not possible to remove it because there are multiple deployments using the same table)

Relevant log output

No response

IPFS hash

No response

Subgraph name or link to explorer

No response

Some information to help us out
  • Tick this box if this bug is caused by a regression found in the latest release.
  • Tick this box if this bug is specific to the hosted service.
  • I have searched the issue tracker to make sure this issue is not a duplicate.
OS information

macOS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the graphman drop --help entry point and trace how its deployment identifier is resolved when a namespace is supplied. Confirm the current behavior across shards and define completion as preventing namespace values from being accepted as deployment identifiers, while clarifying whether shard-specific removal is in scope. No file or test path is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.