graphprotocol / graphprotocol/graph-node

[Help] Do non-fatal errors get unfailed?

Open
#5,159 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement ops Stale
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Description

I'm trying to better understand how graph node handles subgraph failures and I learned that graph node automatically unfails subgraphs on initialization and during other aspects of the subgraph lifetime.

Based on this comment and this comment it seems that only fatal errors are unfailed while non-fatal errors persist. Is that correct?

Is there a way to query the database and know if a subgraph will be unfailed at some point in the future or is that managed entirely through in memory?

Ninja edit: it seems that non-fatal errors can get wiped too eg here and here where None is passed to the non_fatal_errors vector - might this be a bug?

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out
  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced sections of store/postgres/src/deployment_store.rs, especially the lines handling fatal and non-fatal errors. Trace how subgraph failure state and the non_fatal_errors vector are persisted and cleared, then determine whether the observed behavior is intentional or a bug and what database state, if any, predicts un failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres, rust
Domain
backend, databases
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.