graphprotocol / graphprotocol/graph-node
improving response for `index-node` subgraph features API
Open
@incrypto32 is already working on this.
Since Jan 22, 2024.
area/graphql
Stale
- Dominant language
- Rust
- Stars
- 3.2k
- Forks
- 1.1k
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
I think it is built in assumption that if you give an ID of subgraph you will get result back. But in the case where we cannot find that ID it just throws.
So we can either consider making index-node API that field be non-null or we have union of responses where we can define the error message of NotFound https://blog.logrocket.com/handling-graphql-errors-like-a-champ-with-unions-and-interfaces/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.