graphprotocol / graphprotocol/graph-node

Add unit tests for edge cases in polling handlers

Open
#4,885 2 comments 0 reactions 1 assignee View on GitHub

@incrypto32 is already working on this.

Since Sep 22, 2023.

enhancement Stale testing
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Description

Polling handlers have a few edge cases and hardcoded conditions. It would be good to add some unit tests and also to extract the condition checking into a function to make it more robust

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out
  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.