graphprotocol / graphprotocol/graph-node

[Feature] Replace all custom env. var. expansion logic for configuration files with `a8m/envsubst`

Open
#4,678 4 comments 1 reaction 1 assignee View on GitHub

@neysofu is already working on this.

Since Jun 6, 2023.

enhancement Stale
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Description

graph-node supports env. var. expansion in certain sections of the configuration files, and we also ship envsubst in the official Docker image for more complex use cases. I'd argue it makes most sense to drop our custom env. var. expansion logic and automatically invoke envsubst in the start script. This benefits us in three ways:

  1. Less code – yay, always a win.
  2. We enable env. var. expansion in all sections of the configuration files, as opposed to just some of them.
  3. We get support for default values and other advanced features of envsubst, like custom evaluation expressions.
Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out
  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.