graphprotocol / graphprotocol/graph-node

Tests for grafting of file data sources

Open
#4,334 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale testing
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

The entity copy query used by grafting has special cases for each combination of source and target has_causality_region value:
https://github.com/graphprotocol/graph-node/blob/7118fd82148c49da88f59043a73a84598be19116/store/postgres/src/relational_queries.rs#L3583-L3599

Except for the noop (false, false), these are not currently covered by our tests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in store/postgres/src/relational_queries.rs at lines 3583-3599 and inspect the grafting entity copy query's has_causality_region branches. Add test coverage for the three non-noop source/target combinations, then run the relevant test suite and confirm those cases pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, rust
Domain
database, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.