graphprotocol / graphprotocol/graph-node

Non-fatal error not showing in indexing status API

Open
#4,329 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

This should've been fixed on https://github.com/graphprotocol/graph-node/pull/3350 (@neysofu). But on hosted I'm seeing the following entry in subgraph_error:

                                id                                |                  subgraph_id                   |                                                                                                                                                                                                                                                             message                                                                                                                                                                                                                                                              |                             block_hash                             |  handler   |  vid  | block_range | deterministic |          created_at
------------------------------------------------------------------+------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+------------+-------+-------------+---------------+-------------------------------
 e3b8d7b092745350b123a0ef8cc2a317b8022d0d7297f06ae402a432c1211023 | QmZM7qcyrBwBAKATQ8fBJe1f3dnh4M76afYM2kFqn8KWJQ | Mapping aborted at ~lib/@graphprotocol/graph-ts/chain/ethereum.ts, line 448, column 6, with message: Call reverted, probably because an `assert` or `require` in the contract failed, consider using `try_feeGrowthGlobal1X128` to handle this in the mapping.  wasm backtrace:     0: 0x40d6 - <unknown>!~lib/@graphprotocol/graph-ts/chain/ethereum/ethereum.SmartContract#call           1: 0x410b - <unknown>!src/types/Factory/Pool/Pool#feeGrowthGlobal1X128          2: 0x44d6 - <unknown>!src/mappings/core/handleSwap   | \xa27795b7df8341e1b48113b2a866bfcf3d642eaaa9236f7df08dd19991bd90a7 | handleSwap | 52605 | [7729783,)  | t             | 2023-01-20 03:55:31.289339+00

But the indexing status query:

{ 
    indexingStatuses(subgraphs: ["QmZM7qcyrBwBAKATQ8fBJe1f3dnh4M76afYM2kFqn8KWJQ"]) { 
        health
        nonFatalErrors {
            message
        }
    }
}

returns empty:

{
    "data": {
        "indexingStatuses": [
            {
                "health": "unhealthy",
                "nonFatalErrors": []
            }
        ]
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read pull request #3350 first, then trace the indexingStatuses query and compare its nonFatalErrors result with the shown subgraph_error entry. Reproduce the query for the supplied subgraph ID and identify where the stored error is omitted; done means the matching non-fatal error appears in nonFatalErrors.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, rust
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.