graphprotocol / graphprotocol/graph-node
Failed flag should be cleared even if there is no fatal error
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.2k
- Forks
- 1.1k
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Description
We've seen a few times subgraphs that are syncing fine, but have the failed flag set and no fatal error. I'm not sure how this happens, it probably shouldn't, but one thing we can easily address is that the unfail logic is not clearing the failed flag in this situation.
Here it is assuming that if there is no fatal error then the subgraph is not failed:
https://github.com/graphprotocol/graph-node/blob/ee76a6356f79368a61fbb7fbb47ea32568bdd3c7/store/postgres/src/deployment_store.rs#L1437-L1442
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read store/postgres/src/deployment_store.rs around lines 1437-1442 and trace the unfail logic. Verify the behavior when a subgraph has no fatal error but still has the failed flag; done means that flag is cleared in that situation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, rust
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100