graphprotocol / graphprotocol/contracts
sdk: fix test fixture typing issues
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 374
- Forks
- 176
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 4
Description
As mentioned in our call, returning `contracts as L1FixtureContracts` or `as L2FixturContracts` would solve a lot of the type wrangling in the tests, but can be addressed in a separate PR
Originally posted by @pcarranzav in https://github.com/graphprotocol/contracts/pull/872#discussion_r1404587658
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Search the SDK test fixtures for the reported typing errors and read the referenced PR #872 discussion for context; done means the affected tests type-check without the current fixture type wrangling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100