graphprotocol / graphprotocol/contracts
Don't use hardcoded values in e2e config tests
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 374
- Forks
- 176
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 4
Description
A couple of tests use hardcoded values due to them being set with function calls instead of init function:
- RewardsManager --> issuanceRate
- Staking --> delegationTaxPercentage
This could be solved by correctly parsing the value with graph config.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the e2e config tests and the graph config parsing for RewardsManager. Check how issuanceRate and delegationTaxPercentage are currently supplied, then update the tests so both values come from parsed graph configuration and verify the e2e config tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100