graphprotocol / graphprotocol/contracts
GNS tests fail if subgraphNFT's tokenURI has leading zeros
Open
@tmigone is already working on this.
Since May 27, 2022.
- Dominant language
- Solidity
- Stars
- 374
- Forks
- 176
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 4
Description
Will work on reproducing the issue, in the meantime here are logs from a recent failed PR check:
1) GNS
NFT descriptor
without token descriptor:
AssertionError: expected '0x00fae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a' to equal '0xfae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a'
+ expected - actual
-0x00fae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a
+0xfae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a
at Context.<anonymous> (test/gns.test.ts:1042:27)
2) GNS
NFT descriptor
without token descriptor and baseURI:
AssertionError: expected 'ipfs://0x00fae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a' to equal 'ipfs://0xfae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a'
+ expected - actual
-ipfs://0x00fae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a
+ipfs://0xfae00cac62e26a062ca75eb35392df730f5e6c84aa36aa7d199b4bd713f73a
at Context.<anonymous> (test/gns.test.ts:1055:39)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.