graphprotocol / graphprotocol/contracts
We have governor public, and a getter called getGovernor
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 374
- Forks
- 176
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 4
Description
We have on Controller:
address public governor;
and
/**
* @notice Getter to access governor
*/
function getGovernor() external override view returns (address) {
return governor;
}
We can use just one. Which one do you like @abarmat ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Controller declaration and inspect the interface implied by the getGovernor override, then search for usages of both governor and getGovernor. Resolve which accessor the project should retain, update affected references, and verify the contracts compile and their relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100