graphile / graphile/crystal

Optimization: OutputPlan should only skip AccessStep if it could be tree-shaken

Open
#2,530 0 comments 0 reactions 0 assignees View on GitHub
✨ feature
Dominant language
TypeScript
Stars
12.9k
Forks
625
Avg merge
5h 23m
Merged PRs (30d)
24

Description

Currently all OutputPlan that reference a suitable AccessStep will skip the access step and use the expression hoping that it can be optimized away. Instead, we should only do this if the AccessStep _can_ be tree shaken away (ignoring OutputPlans) - if not, since we've already calculated it we should have the OutputPlan use the precalculated values.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.