graphile / graphile/crystal

Should `getFirst` have an alias `setLimit`

Open
#2,399 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
12.9k
Forks
625
Avg merge
5h 23m
Merged PRs (30d)
24

Description

### Summary

I'm not sure I get all the steps correctly, but if so:
As discussed in [discord thread](https://discord.com/channels/489127045289476126/1346789719954161756), setFirst is not very expected on pg class steps. In the channel Benjie proposed to "I should probably add a `setLimit` alias for `setFirst`", which, in my opinion may add a confusion. What I would rather expect, to only have `setLimit`, as we are in the context of PgClass step. `setFirst` makes more sense when we are in the context of `connection` step.

### Additional context

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.