graphile / graphile/crystal

Unclear error message thrown on non-valid orderBy (e.g. non-array)

Open
#1,854 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
12.9k
Forks
625
Avg merge
5h 23m
Merged PRs (30d)
24

Description

When this occurs you only get a single message: "Invalid!", quite difficult to track down where the issue is.

https://github.com/graphile/crystal/blob/818b0e619949a3e7a89fea16430f6b4e4bd726aa/graphile-build/graphile-build-pg/src/plugins/PgConnectionArgOrderByPlugin.ts#L238

Also, side note. Shouldn't `null` be a valid input? Or should it just be completely absent? It isn't a required input ofc.

EDIT:

I see that my above comment is only applicable to response, not request.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.