graphhopper / graphhopper/graphhopper

MaxWeightExceptParser doesn't suppport `maxweightrating:conditional` and others

Open
#3,378 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.7k
Forks
2k
Avg merge
15h 58m
Merged PRs (30d)
3

Description

**Describe the bug**

We currently support the conditional variant of the `maxweight` tag as well as the more broad tagging schema `{ACCESS}:conditional`

Missing variants:

* `maxweight:{ACCESS}:conditional` like `maxweight:hgv:conditional` [Taginfo](https://taginfo.openstreetmap.org/keys/maxweightrating%3Ahgv%3Aconditional)
* `maxweightrating:conditional` [Taginfo](https://taginfo.openstreetmap.org/keys/maxweightrating%3Aconditional)
* `maxweightrating:{ACCESS}:conditional` [Taginfo](https://taginfo.openstreetmap.org/keys/maxweight%3Ahgv%3Aconditional)

**To Reproduce**

Steps to reproduce the behavior. For examples:

1. checkout recent and stable version of GraphHopper
2. link to your OSM pbf
3. include the config.yml you are using
4. run `java -Ddw.graphhopper.datareader.file=your.osm.pbf -jar *.jar server config-example.yml`

Instead of a manual reproduction it would be even better to have a unit or integration test reproducing the issue.

**Expected behavior**

The MaxWeightExceptParser should handle the conditional variants of the tags the OSMMaxWeightParser supports.

Contributor guide

Open the contributing guide

Research direction

Start by locating MaxWeightExceptParser and OSMMaxWeightParser, then compare how each recognizes conditional tags. Add coverage for the three listed tag variants and verify that MaxWeightExceptParser handles them consistently with the tags supported by OSMMaxWeightParser.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.