grafana / grafana/vscode-jsonnet

v0.6.0 Seems to ignore configurations

Open
#41 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
86
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Hi

I've updated the extensions to v0.6.0 and noticed that the `PadArrays` parameter doesn't work anymore.

Output with v0.6.0:
```
time="2024-03-06T10:18:41+01:00" level=info msg="Starting the language server"
time="2024-03-06T10:18:41+01:00" level=info msg="Initializing jsonnet-language-server version 0.13.1"
time="2024-03-06T10:18:41+01:00" level=info msg="Reading stdlib"
```

Output after downgrading to v0.5.1:
```

time="2024-03-06T10:19:04+01:00" level=info msg="Starting the language server"
time="2024-03-06T10:19:04+01:00" level=info msg="Initializing jsonnet-language-server version 0.13.1"
time="2024-03-06T10:19:04+01:00" level=info msg="Reading stdlib"
time="2024-03-06T10:19:04+01:00" level=info msg="configuration updated: {ResolvePathsWithTanka:false JPaths:[/Users/simonbeck/repos/appcat/component-appcat/lib/ /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/commodore /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/kapitan] ExtVars:map[] ExtCode:map[] FormattingOptions:{Indent:2 MaxBlankLines:2 StringStyle:1 CommentStyle:1 PrettyFieldNames:true PadArrays:true PadObjects:true SortImports:true UseImplicitPlus:true StripEverything:false StripComments:false StripAllButComments:false} EnableEvalDiagnostics:true EnableLintDiagnostics:true}"
time="2024-03-06T10:19:04+01:00" level=info msg="configuration updated: {ResolvePathsWithTanka:false JPaths:[/Users/simonbeck/repos/appcat/component-appcat/lib/ /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/commodore /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/kapitan] ExtVars:map[] ExtCode:map[] FormattingOptions:{Indent:2 MaxBlankLines:2 StringStyle:1 CommentStyle:1 PrettyFieldNames:true PadArrays:true PadObjects:true SortImports:true UseImplicitPlus:true StripEverything:false StripComments:false StripAllButComments:false} EnableEvalDiagnostics:true EnableLintDiagnostics:true}"
time="2024-03-06T10:19:05+01:00" level=info msg="configuration updated: {ResolvePathsWithTanka:false JPaths:[/Users/simonbeck/repos/appcat/component-appcat/lib/ /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/commodore /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/kapitan] ExtVars:map[] ExtCode:map[] FormattingOptions:{Indent:2 MaxBlankLines:2 StringStyle:1 CommentStyle:1 PrettyFieldNames:true PadArrays:true PadObjects:true SortImports:true UseImplicitPlus:true StripEverything:false StripComments:false StripAllButComments:false} EnableEvalDiagnostics:true EnableLintDiagnostics:true}"
time="2024-03-06T10:19:05+01:00" level=info msg="configuration updated: {ResolvePathsWithTanka:false JPaths:[/Users/simonbeck/repos/appcat/component-appcat/lib/ /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/commodore /Users/simonbeck/Library/Python/3.10/lib/python/site-packages/kapitan] ExtVars:map[] ExtCode:map[] FormattingOptions:{Indent:2 MaxBlankLines:2 StringStyle:1 CommentStyle:1 PrettyFieldNames:true PadArrays:true PadObjects:true SortImports:true UseImplicitPlus:true StripEverything:false StripComments:false StripAllButComments:false} EnableEvalDiagnostics:true EnableLintDiagnostics:true}"
```

After downgrading the arrays are padded correctly again.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the v0.6.0 versus v0.5.1 behavior in the VS Code extension and follow the language-server configuration path for the PadArrays parameter. Done means v0.6.0 applies PadArrays and produces padded arrays as the older version does.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.