grafana / grafana/shared-workflows
PRs can still be merged with failing workflows
- Dominant language
- Go
- Stars
- 26
- Forks
- 49
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 36
Description
We had [this failing run](https://github.com/grafana/shared-workflows/actions/runs/11369868620) but we still merged #147 and it broke users.
It's because this check isn't required. Conditional checks can't simply be made required, or else they will block pull requests which don't change the files they trigger on.
Possible fixes:
1. Make checks unconditional, just run them always
2. Move the conditionality to runtime using a "changed files" type of action
3. Use our deployment of https://github.com/palantir/policy-bot and make these checks conditional _if triggered_ by writing a `.policy.yml` containing rules that replicate the file triggers, or using a generator (we have one internally in `deployment_tools` - we could open source that by moving it to this repo).
Contributor guide
Assessment
This issue has not been assessed yet.