grafana / grafana/pyroscope

Nodes in diff view shows the sum of the left and right samples

Open
#811 1 comment 0 reactions 0 assignees View on GitHub
backend frontend type/bug
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

When viewing a diff, I think it makes sense to consider one of the profiles (the left one?) as the base, and the other one the diff. In this sense, we would expect to see the number of samples in a node to be either the samples in the left node, the samples in the right node, or something in between, but not the sum of the left and right samples, as it's happening now:

![diff-bug](https://user-images.githubusercontent.com/80059/153250231-613be455-1915-4265-aec1-a36eb19a76ab.png)

The same happens with the node offsets, they are the sum of both left and right

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.