Implement store-gateway block closing
Open
- Dominant language
- Go
- Stars
- 11.7k
- Forks
- 802
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 80
Description
When serving queries from bucket store-gateways open blocks, but they are never closed:
https://github.com/grafana/pyroscope/blob/0f7587769d9aee15579ea4d40ff19ca634f15b2c/pkg/storegateway/query.go#L199
We should implement reference counting and also define a block idle time.:
https://github.com/grafana/pyroscope/blob/0f7587769d9aee15579ea4d40ff19ca634f15b2c/pkg/phlaredb/block_querier.go#L2083-L2094
Reported via the community slack in thread:
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.