Calculate sample rate correctly
- Dominant language
- Go
- Stars
- 11.7k
- Forks
- 802
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 80
Description
The flamebearer metadata passes the sample rate to the frontend: https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/og/structs/flamebearer/flamebearer.go#L85, we currently hard code the value:
https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/model/flamegraph.go#L128
While the older version of flamebearer calculated it from PeriodDuration:
https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/og/structs/flamebearer/convert/convert.go#L199-L204
In reality the data in Duration is not propagated correctly in our query path as those values remain unpopulated.
https://github.com/grafana/pyroscope/issues/4192
Related #3342
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.