grafana / grafana/pyroscope

Implement GoPgo.AggregateCallees outside of merges if possible

Open
#4,424 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

When fetching `pprof` for PGO purposes via `SelectMergeProfile`, an option can be passed to aggregate callees:

https://github.com/grafana/pyroscope/blob/b1614a08cdc4edd8903b00b04f405285794e1f4f/api/types/v1/types.proto#L101

The way this is implemented right now relies on the aggregation happening during profile merges, however we could have cases where profiles are returned as they are (without merging). See if we can implement this in an alternative way.

Related to #4421

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.