grafana / grafana/pyroscope

Implement backend top table (self, total)

Open
#4,414 2 comments 0 reactions 1 assignee Claimed by @alsoba13 View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Is your feature request related to a problem? Please describe.

The UI currently derives the functions TOP table from the flame graph. As a result of truncation happening on the flame graph data (through maxNodes), the "self" top table might be containing significant parts of "other" resource usage.

Image

#### Describe the solution you'd like

We should calculate the top k list on the backend for each self and total and return the TOP k elements separately to the flamegraph's data.

#### Alternatives

- Just don't display others in the top table.
- Detail what self usages others has, but don't keep the tree structure.

#### Additional context

I am still a bit unsure about, how tricky the mismatches between numbers on the table and the flamegraph are for users to comprehend. Also

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.