grafana / grafana/pyroscope

Document push api RawSample.ID field

Open
#4,388 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

1. It seems it's currently undocumented if the ID should be UUID. Later down the ingestion pipeline we seem to expect it to be UUID. We should document if the ID field should be UUID and what happens if it is empty or not UUID.

2. It looks like we currently ignore (do not pas further then infesters) the user provided ID field and only maybe include in the distributor errors.
We generate new UUID when pass a profile down the ingestion pipeline, both for ingesters and segment writers. I think it makes sense to use the user provided ID for at least one case when we send profiles to segment writers and there is no pprof split.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.