grafana / grafana/pyroscope

Differentiate between different label scopes

Open
#4,262 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

We currently treat external labels (or series label), which are applying to whole profile as received, in a similar way as sample labels (or pprof labels).

This is at best confusing and at worst it leads to data loss, when invalid sample labels prevent a profile from being ingested or existing external labels get overwritten by sample labels with the same name.

I do think going forward we need treat those as completely separate labels, a bit like Otel Traces has resource and span attributes.

This problem will become also more pressing as we adopt the new [Otel Profiles](https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/profiles/v1development/profiles.proto) model, which also features "profile" and "location" attributes.

This will require substantial changes how we validate, distribute and query label.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.