grafana / grafana/pyroscope

V2: Query API incompatibility around missing time windows

Open
#4,016 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Describe the bug
A clear and concise description of what the bug is.

When using the v2 mode, the API behaves directly, it seems to treat the time window as required:

```
$ curl -H "content-type: application/json" -d '{"label_names":["__profile_type__"]}' "http://v1/querier.v1.QuerierService/Series"
{"labelsSet":[{"labels":[...]}]}

$ curl -H "content-type: application/json" -d '{"label_names":["__profile_type__"]}' "http://v2/querier.v1.QuerierService/Series"
{"code":"invalid_argument","message":"missing time range in the query"}%

```

#### Expected behavior

Follow the same API behaviour, with and without v2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.