grafana / grafana/pyroscope

`helm install --wait` results in a failed deployment

Open
#3,385 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

The Helm installation instructions for the microservice mode suggest the following command:

```
curl -Lo values-micro-services.yaml https://raw.githubusercontent.com/grafana/pyroscope/main/operations/pyroscope/helm/pyroscope/values-micro-services.yaml
helm -n pyroscope-test install pyroscope grafana/pyroscope --values values-micro-services.yaml
```

A commonly used flag for `helm install` is `--wait`, which makes sure all pods are up and ready before the command exits, waiting for X minutes (configurable via the `--timeout` flag). If users use the `--wait` flag directly or via a helm wrapper, the Pyroscope installation will currently fail. This is because the bucket is created in Minio after `helm install` completes, which in this case will not happen since store-gateways need a bucket to get into the ready state.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.