grafana / grafana/pyroscope

Jsonnet dashboards job selectors are not aligned with monitoring resources

Open
#3,223 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Describe the bug
Jsonnet dashboards `job` selectors are not aligned with monitoring resources.
`job` selectors in panels use `PodMonitor` [syntax](https://github.com/grafana/pyroscope/blob/main/operations/pyroscope/jsonnet/pyroscope-mixin/pyroscope-mixin/dashboards/pyroscope-reads.libsonnet#L19), while the monitoring is [deployed](https://github.com/grafana/pyroscope/blob/main/operations/pyroscope/helm/pyroscope/templates/servicemonitor.yaml) with `ServiceMonitor`, and the job names are service names.

#### To Reproduce
Steps to reproduce the behavior:
- deploy Pyroscope using Helm, enabling monitoring (`serviceMonitor.enabled: true`)
- generate dashboards and import them into Grafana

#### Expected behavior

Prometheus requests from the panels should be aligned with metrics from service monitors.

#### Environment

Kubernetes/Helm

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.