grafana / grafana/pyroscope

Ensure we recover from panics in all API originating paths

Open
#3,190 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

We currently are not recovering panics in all cases, when we spawn up async processing in goroutines. That leaves esp. ingesters vulnerable to data loss after a panic.

I am proposing we check all relevant paths and consider replacing it with: https://github.com/kucherenkovova/safegroup

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.