grafana / grafana/pyroscope

Add support grpc.health.v1.Health

Open
#2,956 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Is your feature request related to a problem? Please describe.

When deployed on baremetal and use consul for service discovery, it is helpful to rely on [GRPC checks](url) to properly advertise a node. However it seems like pyroscope does not support GRPC check.

```
rpc error: code = Unimplemented desc = unknown service grpc.health.v1.Health
```

#### Describe the solution you'd like

Add support for grpc.health.v1.Health

#### Describe alternatives you've considered

Instead of using the proper GRPC check, one could use the TCP check but doing so is unperfect:
* it only check if TCP is open
* it spams the log
```
{"caller":"tcp_transport.go:253","component":"memberlist TCPTransport","err":"EOF","level":"warn","msg":"failed to read message type","remote":"10.0.9.52:56358","ts":"2024-01-22T08:34:50.511091868Z"}
```

#### Additional context

See:
* https://github.com/grpc/grpc/blob/master/doc/health-checking.md
* https://developer.hashicorp.com/consul/docs/services/usage/checks#grpc-checks

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.