grafana / grafana/pyroscope

Remove input labels from the LabelNames API response

Open
#2,792 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Is your feature request related to a problem? Please describe.

When calling the `LabelNames` API with label selectors, the passed labels are returned in the response. E.g., if we pass a label selector such as `{container="ingester", pod="ingester-1"}`, the response will contain `container` and `pod` as label names (among other results). Since they are already selected, they don't serve a purpose and the existing frontends have logic to filter them out.

#### Describe the solution you'd like

We should remove the request labels from the response, as they are never used.

#### Additional context

https://github.com/grafana/grafana/pull/78861#discussion_r1409922759

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.