grafana / grafana/pyroscope

Fix how pyroscope is archived

Open
#2,781 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Is your feature request related to a problem? Please describe.

Iḿ following the getting started guides of Pyroscope/Grafana. In the ["Download and Configure" section of the docs](https://grafana.com/docs/grafana/latest/getting-started/build-first-dashboard/), there is the location (and instruction) to download the binary.

The archive is located at: https://github.com/grafana/pyroscope/releases/download/v1.0.0/pyroscope_1.0.0_linux_amd64.tar.gz

The issue regards to `pyroscope_1.0.0_linux_amd64.tar.gz` not packaging the files inside a folder; the consequence is having unexpected files (`CHANGELOG.md`, `LICENSE`,` `README.md`, `pyroscope`) all over the place, potentially overwriting other files.

```bash
# Download Pyroscope v1.0.0 and unpack it to the current folder
curl -fL https://github.com/grafana/pyroscope/releases/download/v1.0.0/pyroscope_1.0.0_linux_amd64.tar.gz | tar xvz
```

It is nice when we unpack "something", and "something" content happens to be inside "something" folder.

#### Describe the solution you'd like

I would like to do `tar -xvzf pyroscope_1.0.0_linux_amd64.tar.gz` and have the contents of the archive inside the newly create folder `pyroscope_1.0.0_linux_amd64`:

```bash
pyroscope_1.0.0_linux_amd64
├── CHANGELOG.md
├── LICENSE
├── pyroscope
└── README.md
```

Thanks

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the v1.0.0 archive behavior with the curl and tar command shown in the issue, then trace the release packaging configuration that produces pyroscope_1.0.0_linux_amd64.tar.gz. Done means the archive extracts into a pyroscope_1.0.0_linux_amd64 directory containing CHANGELOG.md, LICENSE, README.md, and the pyroscope binary.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.