Duplicate Labels not De-Duping across SDKs (Go & JS)

Open

#2,712 opened on Nov 17, 2023 2 comments 0 reactions 0 assignees View on GitHub

Description

#### Describe the bug
When forwarding labels, deduping seems to not happen correctly across languages/SDKs

See: two "in_use_space" labels under memory? I'd expect there to only be one

![CleanShot 2023-11-16 at 17 55 13](https://github.com/grafana/pyroscope/assets/5499880/8d48a6e9-f4be-4bdf-8fb6-78f9f102ca4a)

Querying the "incorrect" label for the language yields no results

Our Golang Router service with the bottom "inuse_space" label

![CleanShot 2023-11-16 at 18 00 17](https://github.com/grafana/pyroscope/assets/5499880/92f58d7e-6b18-438b-97ce-1f8429887470)

If you switch to our NodeJS Backboard service, you get nothing, until you switch to the 2nd bottom inuse_space label

![CleanShot 2023-11-16 at 18 01 14](https://github.com/grafana/pyroscope/assets/5499880/08c29e68-bf49-4e9b-8352-6646f0547da0)

![CleanShot 2023-11-16 at 18 01 47](https://github.com/grafana/pyroscope/assets/5499880/b1e640a6-4318-460d-80e2-07867ed3068d)

#### To Reproduce
Steps to reproduce the behavior:

1. Start Pyroscope (SHA or version)
2. Send telemetry from both a NodeJS and Golang SDK
3. Observe duplicate labels

#### Expected behavior

Just one label

#### Environment

- Infrastructure: Kubernetes
- Deployment tool: helm

#### Additional Context

I assume this is a pyroscope mapping thing? But it could also be an SDK issue or a Grafana issue :S

No contributing guide indexed for this repository

This issue has not been assessed yet.