grafana / grafana/pyroscope

Missing http metrics in the querier.

Open
#2,709 0 comments 0 reactions 0 assignees View on GitHub
ops v1
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

When using the query-frontend, querier actually are queried without the http server and this means we're missing http metrics for all calls to queriers.

We should be able to a metrics middleware there https://github.com/grafana/pyroscope/blob/main/pkg/querier/grpc_handler.go#L9

If possible we should use the same as the http server here https://github.com/grafana/pyroscope/blob/main/pkg/phlare/modules.go#L425

However that seems hards seems it relies on http registration to match routes and those seems to not happen in that case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.