grafana / grafana/pyroscope

Implement Otel Logs for all rideshare-examples

Open
#2,584 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

Currently we only ship logs via otel in the golang rideshare demo.

To better show the value of using OTLP for profiles, traces and logs we should also ship those for other language examples:

```[tasklist]
- [x] Golang https://github.com/grafana/pyroscope/pull/2476
- [ ] Ruby
- [ ] Python, Example usage https://github.com/open-telemetry/opentelemetry-python/blob/main/docs/examples/logs/example.py
- [ ] .Net
- [ ] Java
- [ ] Rust
```

For the matching to work we should use the same service name for both and ideally also expose the region and host_name with resource tags.

Also we need to set a resource called `loki.resource.labels` with the tags that we want to become Loki labels. Those names need to include the original name (with `.`), as only later characters not allowed in Loki labels get translated into `_`. So `service.name` becomes `service_name`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.