grafana / grafana/pyroscope

Makefile's windows-dev fails without Dockerfile.window

Open
#2,500 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

#### Describe the bug
From checking the code I observed that [`windows-dev`](https://github.com/grafana/pyroscope/blob/e799b75a2f40ac73fcd75d12bd986b8557a5e229/og/Makefile#L268) target trys to build an image of a non-existing `Dockerfile.windows`

#### To Reproduce
1. Run `make windows-dev` inside `og/`

#### Expected behavior
Don't have this target or have a Dockerfile defined

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.