Deduplication must respect profiles with identical timestamps within the same series
Open
storage
v1
- Dominant language
- Go
- Stars
- 11.7k
- Forks
- 802
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 80
Description
[At deduplication](https://github.com/grafana/pyroscope/blob/main/pkg/querier/select_merge.go#L222) we discard profiles if their timestamps and labels match:
https://github.com/grafana/pyroscope/blob/8efd7c176a0b6de02ebcc9aa37c5aab1bd7c7dde/pkg/querier/select_merge.go#L254-L258
Sometimes distinct profiles of the same series may have the same timestamps (millisecond precision), which results in partial reads. Potentially, this could be fixed by #2480 (#2443)
/cc @cyriltovena
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.