grafana / grafana/pyroscope

Allow S3 Storage Provider to support sts_endpoint

Open
#2,470 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

**Is your feature request related to a problem? Please describe.**

Minio has added [sts support](https://min.io/docs/minio/kubernetes/upstream/developers/sts-for-operator.html) to work with the k8s service account JWTs. Currently because it is a different url to hit for sts, we are unable to leverage this feature.

**Describe the solution you'd like**

objstore has added the sts_endpoint in their [configuration file](https://github.com/thanos-io/objstore/blob/main/providers/s3/s3.go#L143), if that could be added to the s3 configuration that would be great!

**Describe alternatives you've considered**

manually creating a service account.

**Additional context**

https://min.io/docs/minio/kubernetes/upstream/developers/sts-for-operator.html
https://github.com/thanos-io/objstore/blob/main/providers/s3/s3.go#L143

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.