Flamegraph stability
Open
backend
type/bug
ux
v1
- Dominant language
- Go
- Stars
- 11.7k
- Forks
- 802
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 80
Description
Currently, if max_nodes parameter is set, and the returned flamegraph has truncated nodes (named "other"), its structure may be unstable. The cause is the fact that flamegraphs are merged in non-deterministic order and therefore the set of truncated nodes varies. This should be fixed by ensuring that flamegraphs are sorted (e.g by request time) before the merge:
https://github.com/grafana/pyroscope/blob/8e158f44094cce241605a63e1717746080f967ed/pkg/frontend/frontend_select_merge_stacktraces.go#L60-L67
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.