grafana / grafana/pyroscope

Close parquet.Rows on Flush

Open
#2,172 2 comments 0 reactions 1 assignee Claimed by @simonswine View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

I stumble on this recently but one place we don't close the Rows from `parquet.RowGroup`. We should definitively do this to avoid leaking ressources.

This is happening when flushing all rowgroups

https://github.com/grafana/pyroscope/blob/next/pkg/phlaredb/profile_store.go#L373

We could either close in that function or push down closing into the inner tree used for merging.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.