grafana / grafana/pyroscope

Reuse Profiles with stacktraces samples

Open
#2,066 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

The biggest memory usage comes from actual samples within profiles. Those are flush once they reach a certain amount default (100_000):

https://github.com/grafana/phlare/blob/arrow-experiment/pkg/phlaredb/profile_store.go#L326-L331

We should be able to reuse then between row group flush but also when creating a new head.

I suspect we should also investigate if we could use a better representation for those profiles and samples like using the parquet.Buffer.
Doing so will also de-amplify serialisation when flushing data.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.