grafana / grafana/pyroscope

Tree Iterator Err()

Open
#2,031 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

When using the loser.Tree and finished with it, we never check original iterators (sequence) errors using Err(), this can swallow errors.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the loser.Tree implementation and its iterator-completion path, then inspect how the original sequence iterators expose Err(). Confirm the intended behavior for propagated iterator errors and add coverage showing that those errors are not swallowed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.