grafana / grafana/pyroscope

Rename language `spy-name` to something more intuitive and less abstract

Open
#1,960 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

When pyroscope was started it started with rbspy, py-spy and php-spy. As a result when we refer to the source languages for each of our profilers we refer to them as `spy-name`.

So if you are using:
- go you have to set `spy-name: gospy`
- python we automatically set `spy-name: py-spy`

etc

Now that we are re-thinking some of our labels and configuration options leading up to Pyroscope 1.0 release it seems like a good time to come up with a more solid foundation to build on moving forward post Pyroscope 1.0.

We should do two things:
1. rename `spy-name` field that accompanies all of our integrations to something more intuitive like `source`
2. we should ensure that this field is always either present or derived from somewhere when profiles are sent to the server

Similar to https://github.com/grafana/pyroscope/issues/2055

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.