grafana / grafana/pyroscope

Allow notifications to have links

Open
#1,651 0 comments 0 reactions 0 assignees View on GitHub
frontend
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

Sometimes a notification leads to another page, so it makes sense allowing to click on it to see more info

~Although clicking by default closes that notification IIRC, so may be confusing, so we have to remove that first~

In fact we can just make so that the notifications can receive an arbitrary JSX element as opposed to just a string as it's currently implemented.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the notification implementation and inspect how its current string-only message is rendered and dismissed. Done when notifications can receive an arbitrary JSX element, including a link, and the click behavior is clear rather than unexpectedly closing the notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.