grafana / grafana/pyroscope

Make Table tooltip use accurate units

Open
#1,426 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

For the table we have some logic that makes it so that there is only _one_ unit in the table at a time. This is because it's really hard to read the table or scan for important information if you have to convert units in your head.

A downside of this approach, however, is that sometimes you get a unit that says something like <0.01 minutes or <0.01 days .... This is typically fine imo because if you're seeing <0.01 days, that means that the max value that you're comparing it to is so large that <0.01 days is probably relatively unimportant.

However, now that we have the tooltip, we should have the tooltip show the actual amount in the neares units:
image (25)

so rather than saying <0.01 [units] we should have it say:
- 60 ms (or whatever the proper unit is)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.